-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build error occurs: Bump react, react-dom and @types/react in /src/playground #15816
base: main
Are you sure you want to change the base?
Build error occurs: Bump react, react-dom and @types/react in /src/playground #15816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test this change out locally with the following install scripts (Action run 12304182423) VSCode
Azure CLI
|
Dotnet Test Results 78 files - 39 78 suites - 39 31m 23s ⏱️ - 15m 14s Results for commit 111d4a3. ± Comparison against base commit c404992. This pull request removes 1846 and adds 630 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
53863e9
to
c644037
Compare
Pull request was closed
Forcing rebuild |
OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react), [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) and [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react). These dependencies needed to be updated together. Updates `react` from 18.3.1 to 19.0.0 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.0.0/packages/react) Updates `react-dom` from 18.3.1 to 19.0.0 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.0.0/packages/react-dom) Updates `@types/react` from 18.3.12 to 19.0.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: react dependency-type: direct:production update-type: version-update:semver-major - dependency-name: react-dom dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
c644037
to
8d7d08b
Compare
Forcing rebuild |
Forcing rebuild |
Fix-DependabotPRs.ps1: Forcing rebuild |
@anthony-c-martin Could you take a look or suggest someone? With the update to react 19.0, we now get:
Thanks! |
@anthony-c-martin I added this fix: 111d4a3, see https://react.dev/blog/2024/04/25/react-19-upgrade-guide#useref-requires-argument But I don't see any tests for playground and don't know if it needs manually testing...? |
Bumps react, react-dom and @types/react. These dependencies needed to be updated together.
Updates
react
from 18.3.1 to 19.0.0Release notes
Sourced from react's releases.
... (truncated)
Changelog
Sourced from react's changelog.
... (truncated)
Commits
e137890
[string-refs] cleanup string ref code (#31443)d1f0472
[string-refs] remove enableLogStringRefsProd flag (#31414)3dc1e48
Followup: remove dead test code from #30346 (#31415)07aa494
Remove enableRefAsProp feature flag (#30346)45804af
[flow] Eliminate usage of more than 1-argReact.AbstractComponent
in React ...5636fad
[string-refs] log string ref from prod (#31161)b78a7f2
[rcr] Re-export useMemoCache in top level React namespace (#31139)4e9540e
[Fiber] Log the Render/Commit phases and the gaps in between (#31016)d4688df
[Fiber] Track Event Time, startTransition Time and setState Time (#31008)15da917
Don't read currentTransition back from internals (#30991)Updates
react-dom
from 18.3.1 to 19.0.0Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
989af12
Make prerendering always non-blocking with fix (#31452)e137890
[string-refs] cleanup string ref code (#31443)07aa494
Remove enableRefAsProp feature flag (#30346)cae764c
Revert "[Re-land] Make prerendering always non-blocking (#31268)" (#31355)d49123f
Expose prerender() for SSG in stable (#31298)6c4bbc7
[Re-land] Make prerendering always non-blocking (#31268)d8c90fa
Disable infinite render loop detection (#31088)67fee58
[Fizz] Start initial work immediately (#31079)76aee6f
Revert "Make prerendering always non-blocking" (#31080)0f1856c
Make prerendering always non-blocking (#31056)Updates
@types/react
from 18.3.12 to 19.0.1Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)